Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix split branches #155

Merged
merged 2 commits into from
Mar 15, 2022
Merged

fix split branches #155

merged 2 commits into from
Mar 15, 2022

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Mar 7, 2022

fix #42

@Moelf
Copy link
Member Author

Moelf commented Mar 7, 2022

@tamasgal feel free to test it. the logic now is that we fully expand splited branches:

if the user asks for V and there exists V/blah, we replace V with V/blah automatically, so users get back all branches fully splitted

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #155 (b32cdc0) into master (ad11fb6) will decrease coverage by 0.21%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   91.32%   91.11%   -0.22%     
==========================================
  Files          11       11              
  Lines        1522     1485      -37     
==========================================
- Hits         1390     1353      -37     
  Misses        132      132              
Impacted Files Coverage Δ
src/root.jl 93.53% <50.00%> (-0.56%) ⬇️
src/iteration.jl 89.67% <92.30%> (+0.60%) ⬆️
src/UnROOT.jl 85.71% <0.00%> (-6.60%) ⬇️
src/utils.jl 97.56% <0.00%> (-2.44%) ⬇️
src/displays.jl 75.28% <0.00%> (-0.81%) ⬇️
src/io.jl 88.88% <0.00%> (-0.51%) ⬇️
src/types.jl 93.97% <0.00%> (-0.15%) ⬇️
src/bootstrap.jl 92.97% <0.00%> (-0.12%) ⬇️
src/streamsource.jl 82.25% <0.00%> (-0.10%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad11fb6...b32cdc0. Read the comment docs.

@tamasgal
Copy link
Member

tamasgal commented Mar 7, 2022

Thanks Jerry, I will have a look. I also have a WIP branch with some custom interpretation logic, let's see...

@Moelf Moelf mentioned this pull request Mar 9, 2022
@Moelf
Copy link
Member Author

Moelf commented Mar 15, 2022

CI error is irrelevant.

@Moelf Moelf merged commit f90c4fe into JuliaHEP:master Mar 15, 2022
@Moelf Moelf deleted the fix_split_branches branch May 19, 2022 18:19
Moelf added a commit to Moelf/UnROOT.jl that referenced this pull request Jun 23, 2022
Moelf added a commit to aminnj/UnROOT.jl that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with sub-branches coming from split custom classes
2 participants